Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: deflake TestAbortCountConflictingWrites #98508

Merged

Conversation

nvanbenschoten
Copy link
Member

Fixes #96839.

The test was made flaky by 5129578. See the comment in #96839 (comment) for an explanation.

This commit resolves that flakiness.

Release note: None

Fixes cockroachdb#96839.

The test was made flaky by 5129578. See the comment in
cockroachdb#96839 (comment)
for an explanation.

This commit resolves that flakiness.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 13, 2023

Build succeeded:

@craig craig bot merged commit 36d39aa into cockroachdb:master Mar 13, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/deflake96839 branch March 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: TestAbortCountConflictingWrites failed
3 participants